Skip to content

Set fixed 10 min interval to update news items #26336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Nov 1, 2024

Resolves brave/brave-browser#42021

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@atuchin-m atuchin-m self-assigned this Nov 1, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 1, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@atuchin-m atuchin-m enabled auto-merge (squash) November 1, 2024 14:58
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so we can land asap

@@ -31,7 +31,7 @@ export const getRelativeTime = (time: Date | number) => {
const amount = Math.floor(diff / duration)
return {
formatted: rtf.format(amount, unit ),
updatesIn: duration - (Math.abs(diff - amount)),
updatesIn: 10 * minute,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe do a Math.max instead?

Suggested change
updatesIn: 10 * minute,
updatesIn: Math.max(10 * minute, duration - (Math.abs(diff - amount))),

@atuchin-m atuchin-m merged commit 70595b5 into master Nov 3, 2024
20 checks passed
@atuchin-m atuchin-m deleted the issue/42021-fix-ntp-cpu-usage branch November 3, 2024 19:37
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Nov 3, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.69

@kjozwiak
Copy link
Member

kjozwiak commented Nov 5, 2024

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.73.75 Chromium: 131.0.6778.24 (Official Build) nightly (64-bit)
-- | --
Revision | c3d6b9bdbbdf63fc4831eb0bc8e116e9742e3852
OS | Windows 11 Version 24H2 (Build 26100.2161)

Using the STR/Cases outlined via brave/brave-browser#42021 (comment), ensured that the CPU & GPU are not spiking/increasing to unreasonable levels while idling on a NTP with News enabled as per the following:

  • ensured that the CPU/GPU never increased more than ~5% using 1.73.75 Chromium: 131.0.6778.24
    • in my case, the CPU/GPU never increased more than 2% with the the above build which has the fix
    • with 1.73.68 Chromium: 131.0.6778.14 which doesn't have the fix, the CPU/GPU was reaching ~30% at times while idling
1.73.68 Chromium: 131.0.6778.14 1.73.75 Chromium: 131.0.6778.24
reproduced1 fixed1

The above was also verified on Nightly by @atuchin-m as per brave/brave-browser#42021 (comment).

kjozwiak pushed a commit that referenced this pull request Nov 5, 2024
kjozwiak pushed a commit that referenced this pull request Nov 5, 2024
@bsclifton bsclifton modified the milestones: 1.73.x - Nightly, 1.74.x - Nightly Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave News on NTP consume a lot of CPU
5 participants