Skip to content

[iOS] - Properly handle URL eliding when blobs are given. #26085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Oct 18, 2024

Summary

Resolves brave/brave-browser#41716
Resolves https://github.com/brave/internal/issues/1210

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

image

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Oct 18, 2024
@Brandon-T Brandon-T self-assigned this Oct 18, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner October 18, 2024 05:20
Copy link
Contributor

The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "url parse" and so security team members have been added as reviewers to take a look.

No need to request a full security review at this stage, the security team will take a look shortly and either clear the label or request more information/changes.

Notifications have already been sent, but if this is blocking your merge feel free to reach out directly to the security team on Slack so that we can expedite this check.

@stoletheminerals
Copy link
Contributor

Note: On Chrome Desktop (and Brave Desktop), this is broken as well!

Are you sure? I can't reproduce it on Desktop or Android

@Brandon-T Brandon-T merged commit 2984dc1 into master Oct 18, 2024
18 checks passed
@Brandon-T Brandon-T deleted the bugfix/URLElide-iOS branch October 18, 2024 14:59
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 18, 2024
brave-builds added a commit that referenced this pull request Oct 18, 2024
brave-builds added a commit that referenced this pull request Oct 18, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.26

@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 19, 2024

Verified on iPhone 12 running iOS 18.0 using version 1.73 (27)

1.72.x 1.73.27
IMG_7799 IMG_7798

kjozwiak pushed a commit that referenced this pull request Oct 21, 2024
kjozwiak pushed a commit that referenced this pull request Oct 21, 2024
@bsclifton bsclifton removed this from the 1.73.x - Nightly milestone Nov 6, 2024
@bsclifton bsclifton added this to the 1.74.x - Nightly milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 needs-security-review unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][hackerone] Fix url formatting
8 participants