-
Notifications
You must be signed in to change notification settings - Fork 965
[iOS] - Properly handle URL eliding when blobs are given. #26085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "url parse" and so security team members have been added as reviewers to take a look. |
Are you sure? I can't reproduce it on Desktop or Android |
Released in v1.73.26 |
Verified on
|
Summary
url.SchemeIsBlob()
, and if it is, ALL url parsers fail to parse the host (Swift Foundation URL, GURL, NSURL, etc). The URL ends up having no host or path!URLOrigin
to parse the host and use that as the URL to be formatted. Safari does the same.Resolves brave/brave-browser#41716
Resolves https://github.com/brave/internal/issues/1210
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: