-
Notifications
You must be signed in to change notification settings - Fork 965
[iOS] Show correct options when sharing a temporary doc like a PDF #25496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. It works and still mitigates the flaw.
Tested 1.68.x to confirm the flaw is there.
Tested this PR to confirm the flaw is NOT there.
Tested Sharing (Save PDF to Files) and Apple Wallet (Cineplex Tickets)
90c39ed
to
315c4bd
Compare
Verification PASSED on
Using the STR/Cases outlined via brave/brave-browser#40918 (comment), ensured that Ensuring you can save PDF files via
|
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Ensuring you can save websites as PDFs and save via Save to Files
Example |
Example |
Example |
Example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Resolves brave/brave-browser#40918
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: