Skip to content

context menu fix for cosmetic filter #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 14, 2019
Merged

context menu fix for cosmetic filter #2486

merged 4 commits into from
Jun 14, 2019

Conversation

Snuupy
Copy link
Contributor

@Snuupy Snuupy commented May 23, 2019

Now ready for review.

Closes brave/brave-browser#4417

Submitter Checklist:

Test Plan:

  1. Visit http://raymondhill.net/ublock/adbox.html
  2. Use right click => Block element via selector on red area of text (where it says Should be hidden)
  3. Prompt should show up with a populated selector
  4. Cancel prompt, go to https://cnn.com
  5. Visit https://benzworld.org/forums/w126-s-se-sec-sel-sd/
  6. Use right click => Block element via selector on picture of car on the top
  7. Prompt should show mentioning how selector couldn't be found
  8. Enter a custom selector (ex: table#header)
  9. Confirm content is hidden

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@Snuupy Snuupy force-pushed the contextMenuFix branch 2 times, most recently from c5f96cd to e173c6c Compare June 12, 2019 09:50
@Snuupy Snuupy marked this pull request as ready for review June 12, 2019 11:30
@Snuupy Snuupy changed the title WIP: context menu fix for cosmetic filter context menu fix for cosmetic filter Jun 12, 2019
@bsclifton bsclifton added this to the 0.68.x - Nightly milestone Jun 12, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested - works great 😄 Going to check out CI real quick here...

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified CI looks good (I don't believe any of the failures are tied to this PR; ex: upload to s3). Good to go!

@bsclifton bsclifton merged commit 5e16021 into master Jun 14, 2019
@bsclifton bsclifton deleted the contextMenuFix branch June 14, 2019 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmetic filter is not always working
3 participants