Skip to content

feat(wallet): hide zero balance assets under account #24135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Jun 11, 2024

Resolves brave/brave-browser#38882
In account details/activity screen, only displaying assets that this account owns with balance more than zero. (we currently already display NFT that account owns)

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. unlock wallet
  2. make sure you have some visible assets with zero balance
  3. go to accounts tab
  4. choose an account that has some assets with balance and also the coin type that has some visible assets with zero balance. step into this account
  5. you should see the total number of assets that this account owns and their balance is not zero
  6. tap the # assets
  7. you should see all the assets listed with balance not zero.

@nuo-xu nuo-xu added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Jun 11, 2024
@nuo-xu nuo-xu requested a review from StephenHeaps June 11, 2024 20:24
@nuo-xu nuo-xu self-assigned this Jun 11, 2024
@nuo-xu nuo-xu requested a review from a team as a code owner June 11, 2024 20:24
@nuo-xu nuo-xu force-pushed the wallet/ios-hiding-zero-balance-asset-account-details branch from 7917cbd to f4b5067 Compare June 12, 2024 03:24
Copy link
Collaborator

@StephenHeaps StephenHeaps Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also drop the first assignment to (self.userAssets, self.userNFTs) in update() as both will will just be filtered out for having no balance at this point? We probably want to move it after balance fetch in #24072 but before price fetch

@nuo-xu nuo-xu merged commit ea76bb7 into master Jun 13, 2024
19 checks passed
@nuo-xu nuo-xu deleted the wallet/ios-hiding-zero-balance-asset-account-details branch June 13, 2024 14:07
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Wallet/iOS]: Hide Zero Balance Tokens in Account Details
2 participants