Skip to content

[iOS] - Remove Claude Instant Strings and Rename Llama 13B #23911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented May 30, 2024

Summary

  • Remove ClaudeInstant
  • Rename Llama 13B to Llama 3 8B.

Resolves brave/brave-browser#37988
Resolves brave/brave-browser#38071

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Rename Llama 13B to Llama 3 8B.
@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels May 30, 2024
@Brandon-T Brandon-T added this to the 1.68.x - Nightly milestone May 30, 2024
@Brandon-T Brandon-T self-assigned this May 30, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner May 30, 2024 15:07
@Brandon-T Brandon-T changed the title [iOS] - Remove Claude Instant and Rename Llama 13B [iOS] - Remove Claude Instant Strings and Rename Llama 13B May 30, 2024
@Brandon-T Brandon-T merged commit 0bef935 into master Jun 3, 2024
20 checks passed
@Brandon-T Brandon-T deleted the feature/RemoveClaudeInstant branch June 3, 2024 13:01
Brandon-T added a commit that referenced this pull request Jun 17, 2024
- Remove ClaudeInstant.
- Rename Llama 13B to Llama 3 8B.
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 17.5.1 using version 1.69 (37)

New Install

  • Ensured that Llama 13B strings are replaced with Llama 3 8B in menus and chat.
  • Ensured that Claude Instant strings are removed from Language Models in Leo menu, everywhere in chat and in the advanced settings menu.
  • Ensured that starting new chat will show the correct strings.
  • Ensured that tapping on the (i) in chat shows the dialog box with the correct introduction for the model selected.
  • Ensured Learn More in the dialog box launches the Brave support page.
Example Example Example Example Example
IMG_6505 IMG_6506 IMG_6507 IMG_6508 IMG_6509
IMG_6511 IMG_6512 IMG_6513 IMG_6514 IMG_6515

Existing Users

  • Ensured that upgrading from previous version with Claude Instant set as default LLM will now default to Claude 3 Haiku for non-premium users.
  • Ensured that upgrading from previous version with Claude Instant set as default LLM will now default to Claude 3 Sonnet for premium users.

kjozwiak pushed a commit that referenced this pull request Jun 21, 2024
…24217)

- Remove ClaudeInstant.
- Rename Llama 13B to Llama 3 8B.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Llama 2 with Llama 3 as an AI model [Brave Leo]: Deprecate Claude Instant model
3 participants