Skip to content

don't perturb pixels on google maps #23416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2024
Merged

don't perturb pixels on google maps #23416

merged 1 commit into from
May 3, 2024

Conversation

arthuredelstein
Copy link
Collaborator

@arthuredelstein arthuredelstein commented May 3, 2024

This is a temporary fix for Google Maps; we will revert it once a better fix is found.

Resolves brave/brave-browser#37075

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This is a temporary fix for Google Maps; we will revert it once a better fix is found.
@arthuredelstein arthuredelstein requested a review from a team as a code owner May 3, 2024 16:31
@arthuredelstein arthuredelstein requested a review from bridiver May 3, 2024 16:32
@arthuredelstein arthuredelstein enabled auto-merge (squash) May 3, 2024 16:43
@arthuredelstein
Copy link
Collaborator Author

Thanks for the review!

@arthuredelstein arthuredelstein merged commit c745791 into master May 3, 2024
20 checks passed
@arthuredelstein arthuredelstein deleted the issues/37075 branch May 3, 2024 18:12
@github-actions github-actions bot added this to the 1.67.x - Nightly milestone May 3, 2024
@kjozwiak kjozwiak mentioned this pull request May 6, 2024
24 tasks
@kjozwiak
Copy link
Member

kjozwiak commented May 6, 2024

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.67.66 Chromium: 124.0.6367.118 (Official Build) nightly (64-bit)
-- | --
Revision | 95a0282caa8ea05f77b3c64578abb5f53c1be68e
OS | Windows 11 Version 23H2 (Build 22631.3447)

Using the STR/information provided via brave/brave-browser#37075 (comment), ensured that Google Maps was loading/appearing correctly when using the default shield settings as per the following

Brave Chrome
brave1 google1
brave2 google2
brave3 google3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Maps Highway/Freeway icons render incorrectly
3 participants