Skip to content

[iOS] Shortcuts and User Intents not working when app is not in background (uplift to 1.66.x) #23304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2024
Merged

[iOS] Shortcuts and User Intents not working when app is not in background (uplift to 1.66.x) #23304

merged 1 commit into from
Apr 26, 2024

Conversation

soner-yuksel
Copy link
Contributor

Uplift of #22970
Resolves brave/brave-browser#37403

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@soner-yuksel soner-yuksel added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Apr 26, 2024
@soner-yuksel soner-yuksel added this to the 1.66.x - Beta milestone Apr 26, 2024
@soner-yuksel soner-yuksel self-assigned this Apr 26, 2024
@soner-yuksel soner-yuksel requested a review from a team as a code owner April 26, 2024 18:10
LaurenWags
LaurenWags approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.66.x is approved 👍🏻 QA has verified the PR on 1.67.x/Nightly as per #22970 (comment).

@LaurenWags LaurenWags merged commit 553bb56 into 1.66.x Apr 26, 2024
15 checks passed
@LaurenWags LaurenWags deleted the pr22970_ios_action_external_1.66.x branch April 26, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@soner-yuksel soner-yuksel

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.66.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@soner-yuksel @LaurenWags