Skip to content

Strip Salesforce Marketing Cloud subscriber ID from URLs #23275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Apr 24, 2024

Fixes brave/brave-browser#37847

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Ensure adblocking is set to standard mode (not aggressive).
  2. Open https://brave.com/?et_cid=1234&et_rid=abcd.
  3. Look at the URL bar and confirm that the et_rid parameter was removed. The et_cid should still be there.

@fmarier fmarier requested a review from ryanbr April 24, 2024 23:58
@fmarier fmarier self-assigned this Apr 24, 2024
Copy link
Collaborator

@ryanbr ryanbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmarier fmarier merged commit 6c462e2 into master Apr 25, 2024
20 checks passed
@fmarier fmarier deleted the salesforce-url-param-37847 branch April 25, 2024 03:57
@github-actions github-actions bot added this to the 1.67.x - Nightly milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strip Salesforce Marketing Cloud email tracker
2 participants