Skip to content

[iOS] - Add Skus-Internals WebUI - 1.64.x #22918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

Brandon-T
Copy link
Contributor

Summary

  • Export Skus-UI and add Skus-UI internals interface for iOS

Resolves brave/brave-browser#37222
Uplift of: #22856

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

* Add Skus-Internals for iOS
* Add ability to retrieve AI-Chat skus state
* Add ability for WebUI to show alerts and confirmation dialogs.
@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Apr 3, 2024
@Brandon-T Brandon-T added this to the 1.64.x - Release #4 milestone Apr 3, 2024
@Brandon-T Brandon-T self-assigned this Apr 3, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner April 3, 2024 20:37
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Apr 3, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.64.x approved 👍 QA has verified the PR on Nightly via 1.66.x as per #22856 (comment). More thorough checks will be completed once QA gets an RC build via release where TF can be used to make VPN & Leo purchases.

@kjozwiak kjozwiak merged commit 3014e48 into 1.64.x Apr 5, 2024
@kjozwiak kjozwiak deleted the feature/iOS-Skus-Internals-1.64.x branch April 5, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/storybook-url Deploy storybook and provide a unique URL for each build unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants