Skip to content

[iOS] Move Leo entry point on the search overlay to the bottom. #22879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Apr 2, 2024

Resolves brave/brave-browser#37263

Zrzut ekranu 2024-04-2 o 19 02 13

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@iccub iccub requested a review from a team as a code owner April 2, 2024 17:02
@iccub iccub changed the title [iOS] Move Leo entry point on the search overlay at the bottom. [iOS] Move Leo entry point on the search overlay to the bottom. Apr 2, 2024
@iccub iccub added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Apr 2, 2024
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 17.3.1 using version 1.66.56

  • Ensured Leo entry point is at the bottom of the search overlay.
  • Ensured using the Leo suggestion in search overlay will open Leo UI and send query automatically.

Search Overlay (NTP)

1.66.53 1.66.56
IMG_5924 IMG_5925

Search Overlay (Web)

Example Example
IMG_5927 IMG_5928

Leo Suggestion flow

Example Example Example
IMG_5929 IMG_5926 IMG_5931

kjozwiak pushed a commit that referenced this pull request Apr 5, 2024
…ft to 1.65.x) (#22889)

[iOS] Move Leo entry point on the search overlay to the bottom. (#22879)

Resolves brave/brave-browser#37263
kjozwiak pushed a commit that referenced this pull request Apr 5, 2024
…ft to 1.64.x) (#22888)

[iOS] Move Leo entry point on the search overlay to the bottom. (#22879)

Resolves brave/brave-browser#37263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leo search overlay entry point should be at the bottom of the list
4 participants