Skip to content

[iOS] - Uplift 1.63.x of Leo Bug Fixes QA Iteration 1 #22519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2024
Merged

[iOS] - Uplift 1.63.x of Leo Bug Fixes QA Iteration 1 #22519

merged 2 commits into from
Mar 12, 2024

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Mar 8, 2024 •
edited by kjozwiak
Loading

Summary

  • Fix popover not showing correctly after tapping on `Advanced Settings
  • Fix popover not showing correctly when tapping the info icon while the keyboard is on screen
  • Update strings to lower-case by default (upper-cased in code)
  • Allow QA to be redirected to the release page to manage subscriptions on a release sandboxed build

Uplift of #22517
Resolves brave/brave-browser#36650
Resolves brave/brave-browser#36653
Resolves brave/brave-browser#36656
Resolves brave/brave-browser#36659

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Mar 8, 2024
@Brandon-T Brandon-T added this to the 1.63.x - Release #5 milestone Mar 8, 2024
@Brandon-T Brandon-T self-assigned this Mar 8, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner March 8, 2024 21:02
@Brandon-T Brandon-T force-pushed the bugfix/Leo-iOS-1.63.x branch 3 times, most recently from 50174cd to 8ed2ade Compare March 11, 2024 21:06
@Brandon-T
Fix popover not displaying correctly when something else is presented…
b9fe5f3 
… (keyboard, other controller, etc).

Update strings to be lowercased localized and uppercased in code.
Allow QA to test production links on a release channel.

Fix premium subscription info discrepancy.
The AppStore says the user is subscribed, but Leo says they are not.
We only allow the user to MANUALLY activate premium so this causes a bug.

Fix yet another bug in Skus SDK where order does not refresh automatically
Fix popover clipping on iPad
Regenerate other chat indices instead of just the last one.
Fix textField not being fully tappable.
@Brandon-T Brandon-T force-pushed the bugfix/Leo-iOS-1.63.x branch from 8ed2ade to b9fe5f3 Compare March 11, 2024 21:06
kjozwiak
kjozwiak approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.63.x approved 👍 QA has verified the PR on Nightly using 1.65.x as per #22517 (comment), #22517 (comment), #22517 (comment) & #22517 (comment).

@kjozwiak kjozwiak merged commit 67c9505 into 1.63.x Mar 12, 2024
@kjozwiak kjozwiak deleted the bugfix/Leo-iOS-1.63.x branch March 12, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@Brandon-T Brandon-T

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.63.x - Release #5
Development

Successfully merging this pull request may close these issues.
2 participants
@Brandon-T @kjozwiak