Wait for adblock components to be fully initialized before loading engines (uplift to 1.64.x) #22412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antonok-edm can add more details, but my understanding is that we should be especially careful testing the following scenario with this PR: blocking ads on first install on a slow machine or slow network (Desktop or Android). |
|
@ShivanKaul yep, I've already added detailed test information in the |
kjozwiak
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Uplift into 1.64.x approved 👍 QA has verified the PR on Nightly using 1.65.x as per #22082 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #22082
Resolves brave/brave-browser#35922
Pre-approval checklist:
Pre-merge checklist:
Post-merge checklist: