Skip to content

fix(wallet): Transaction Details status not updated automatically on iOS #22405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

StephenHeaps
Copy link
Collaborator

Resolves brave/brave-browser#36468

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Create a transaction
  2. Do not confirm it, dismiss modal and switch to activity tab
  3. Open pending transaction confirmation & confirm the transaction
  4. Close transaction modal quickly (before it leaves Submitted state), open Transaction Details from Activity tab
  5. Verify Transaction Details modal does update status from Submitted to Confirmed / Error status
transaction.details.status.update.mp4

@StephenHeaps StephenHeaps added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Feb 29, 2024
@StephenHeaps StephenHeaps requested a review from nuo-xu February 29, 2024 22:39
@StephenHeaps StephenHeaps self-assigned this Feb 29, 2024
@StephenHeaps StephenHeaps requested a review from a team as a code owner February 29, 2024 22:39
@StephenHeaps StephenHeaps changed the title fix(wallet): Transaction Details status not updated automatically fix(wallet): Transaction Details status not updated automatically on iOS Feb 29, 2024
@StephenHeaps StephenHeaps merged commit d93ee70 into master Mar 1, 2024
@StephenHeaps StephenHeaps deleted the wallet/transaction-details-status-update branch March 1, 2024 20:00
@github-actions github-actions bot added this to the 1.65.x - Nightly milestone Mar 1, 2024
StephenHeaps added a commit that referenced this pull request Mar 1, 2024
…iOS (#22405)

* Fix Transaction Details not updating transaction status when the status changes.
StephenHeaps added a commit that referenced this pull request Mar 1, 2024
…iOS (#22405)

* Fix Transaction Details not updating transaction status when the status changes.
@srirambv
Copy link
Contributor

srirambv commented Mar 5, 2024

Verification passed on iPhone 13 with iOS 17.4 running 1.65 (56)

  • Verified steps from PR
  • Verified Transaction details screen updates status when transaction confirms/error out
22405.MP4

kjozwiak pushed a commit that referenced this pull request Mar 5, 2024
…iOS (uplift to 1.64.x) (#22431)

fix(wallet): Transaction Details status not updated automatically on iOS (#22405)

* Fix Transaction Details not updating transaction status when the status changes.
kjozwiak pushed a commit that referenced this pull request Mar 5, 2024
…iOS (uplift to 1.63.x) (#22432)

fix(wallet): Transaction Details status not updated automatically on iOS (#22405)

* Fix Transaction Details not updating transaction status when the status changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction Details not updating transaction status automatically
3 participants