Skip to content

fix(wallet): Left-align DApp connections empty state label on iOS #22377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

StephenHeaps
Copy link
Collaborator

@StephenHeaps StephenHeaps commented Feb 28, 2024

Resolves brave/brave-browser#36429

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open Account Details for an Ethereum or Solana account without any DApp permissions (or remove all DApp permissions)
  2. Tap Security row
  3. Verify empty state is left-aligned, and stays left aligned when displayed in multiple lines (iPhone 13 can be used to see 2 lines at default text size)

@StephenHeaps StephenHeaps added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Feb 28, 2024
@StephenHeaps StephenHeaps requested a review from nuo-xu February 28, 2024 14:44
@StephenHeaps StephenHeaps self-assigned this Feb 28, 2024
@StephenHeaps StephenHeaps marked this pull request as ready for review February 28, 2024 20:24
@StephenHeaps StephenHeaps requested a review from a team as a code owner February 28, 2024 20:24
@StephenHeaps StephenHeaps merged commit f7b7994 into master Feb 28, 2024
@StephenHeaps StephenHeaps deleted the wallet/dapp-settings-empty-state branch February 28, 2024 20:36
@github-actions github-actions bot added this to the 1.65.x - Nightly milestone Feb 28, 2024
brave-builds added a commit that referenced this pull request Feb 29, 2024
brave-builds added a commit that referenced this pull request Feb 29, 2024
@srirambv
Copy link
Contributor

srirambv commented Mar 5, 2024

Verification passed on iPhone 13 with iOS 17.4 running 1.65 (56)

  • Verified steps from issue description and PR
  • Verified Dapp connection empty state label is left aligned
Ethereum Solana
image image

kjozwiak pushed a commit that referenced this pull request Mar 5, 2024
kjozwiak pushed a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connected Dapps text has extra padding
3 participants