Skip to content

Twitch channels in auto-contribute list with an underscore character are now linked correctly #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2019
Merged

Twitch channels in auto-contribute list with an underscore character are now linked correctly #2224

merged 1 commit into from
Apr 19, 2019

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Apr 15, 2019 •
edited
Loading

Fixes brave/brave-browser#4045

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Start Brave, enable Rewards
  2. go to https://twitch.tv/anatomyz_2
  3. View live stream for required time and check database and ensure that publisher_id and url point to correct publisher (activity_info, publisher_info and media_publisher_info
  4. Go to videos and view a VOD
  5. Ensure that publisher_id and url point to correct publisher
  6. Go to Rewards page and make sure that publisher is listed in ac table and that clicking on it takes you to correct publisher page.
  7. Tip publisher's live stream and ensure pending_contributions has correct publisher_id
  8. Repeat with VOD
  9. If available, repeat tip with a verified publisher with an underscore in the middle of it's user id and ensure that contribution_info->publisher_id points to correct publisher

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@jasonrsadler jasonrsadler added this to the 0.65.x - Nightly milestone Apr 15, 2019
@jasonrsadler jasonrsadler requested a review from NejcZdovc April 15, 2019 22:13
@jasonrsadler jasonrsadler self-assigned this Apr 15, 2019
@jasonrsadler jasonrsadler changed the title Fixes brave/brave-browser#4045 Twitch channels in auto-contribute list with an underscore character are now linked correctly Apr 16, 2019
@NejcZdovc NejcZdovc force-pushed the media-split branch 5 times, most recently from deeb65a to 8022a70 Compare April 17, 2019 10:11
@jasonrsadler jasonrsadler force-pushed the media-split-twitch-ac-url-fix branch from ba9c67d to 9c999dc Compare April 18, 2019 01:40
@jasonrsadler jasonrsadler changed the base branch from media-split to master April 18, 2019 10:03
@jasonrsadler jasonrsadler force-pushed the media-split-twitch-ac-url-fix branch from 9c999dc to 70c8f9a Compare April 18, 2019 10:17
@jasonrsadler jasonrsadler requested a review from ryanml April 18, 2019 10:19
@jasonrsadler jasonrsadler force-pushed the media-split-twitch-ac-url-fix branch 3 times, most recently from 40d9aa7 to 4a85976 Compare April 18, 2019 16:13
@jasonrsadler jasonrsadler requested a review from NejcZdovc April 18, 2019 16:13
@jasonrsadler jasonrsadler force-pushed the media-split-twitch-ac-url-fix branch from 4a85976 to d9230c3 Compare April 18, 2019 16:33
@jasonrsadler jasonrsadler force-pushed the media-split-twitch-ac-url-fix branch from d9230c3 to 79a8593 Compare April 18, 2019 17:07
Fixes brave/brave-browser#4045
04fab32 
Changed static ref function to not param non-const string

Address PR comments

Moved to single return

Use GetPublisherKey to set id
@jasonrsadler jasonrsadler force-pushed the media-split-twitch-ac-url-fix branch from 79a8593 to 04fab32 Compare April 19, 2019 01:51
@jasonrsadler jasonrsadler requested a review from NejcZdovc April 19, 2019 01:51
@jasonrsadler jasonrsadler merged commit 2e29901 into master Apr 19, 2019
@jasonrsadler jasonrsadler deleted the media-split-twitch-ac-url-fix branch April 19, 2019 10:06
@btlechowski btlechowski mentioned this pull request Jun 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@ryanml ryanml Awaiting requested review from ryanml

Assignees

@jasonrsadler jasonrsadler

Labels
feature/rewards
Projects
None yet
Milestone
0.66.x - Release
Development

Successfully merging this pull request may close these issues.

Wrong twitch channel linked in Auto-Contribute
2 participants
@jasonrsadler @NejcZdovc