Skip to content

Links IAP Leo purchase to desktop #22012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Feb 12, 2024

Resolves brave/brave-browser#35983

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@SergeyZhukovsky SergeyZhukovsky added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Feb 12, 2024
@SergeyZhukovsky SergeyZhukovsky self-assigned this Feb 12, 2024
@SergeyZhukovsky SergeyZhukovsky requested a review from a team as a code owner February 12, 2024 22:46
@SergeyZhukovsky SergeyZhukovsky merged commit 5c908b5 into master Feb 13, 2024
@SergeyZhukovsky SergeyZhukovsky deleted the android_leo_link_subs branch February 13, 2024 13:38
@github-actions github-actions bot added this to the 1.64.x - Nightly milestone Feb 13, 2024
SergeyZhukovsky pushed a commit that referenced this pull request Feb 13, 2024
kjozwiak pushed a commit that referenced this pull request Feb 15, 2024
* Uplift of #22012 (squashed) to beta

* Adds Leo staging switch for Android

---------

Co-authored-by: Serg <[email protected]>
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 8 Pro running Android 14 using the following build(s):

Brave | 1.65.2 Chromium: 122.0.6261.43 (Official Build) canary (64-bit)
Revision | 241c70d7f059bd6e2026f12c9928f56f3608e148
OS | Android 14; Build/UQ1A.240205.004; 34; REL
  • launched 1.65.2 Chromium: 122.0.6261.43 and enabled Leo staging
    • Hamburger Menu -> Settings -> Developer options -> QA Preferences
  • once enabled, purchased Leo premium via Hamburger Menu -> Settings -> Leo -> Go Premium
  • once Leo has been purchased, tapped on Link purchase to your Brave account via the Leo settings
  • ensured that https://account.bravesoftware.com was being used (Staging)
  • used an account that doesn't have any Premium products
  • once logged into the Brave Account, tapped on Link my subscription now
    • ensured that the Success! Your subscription is now linked message was displayed once linked
  • ensured that Leo appeared as a purchased premium product
    • ensured that Purchased on Android is visible/being displayed
Example Example Example Example Example
Screenshot_20240215-145341 Screenshot_20240215-145353 Screenshot_20240215-145357 Screenshot_20240215-145403 Screenshot_20240215-145419
Example Example Example Example
Screenshot_20240215-145654 Screenshot_20240215-150029 Screenshot_20240215-150033 Screenshot_20240215-150056

Once the above was completed/verified, launched 1.62.165 Chromium: 121.0.6167.184 on Win 11 x64 using the following:

  • brave.exe --enable-logging=stderr --env-leo=staging --env-ai-chat.bsg=dev --env-ai-chat-premium.bsg=dev

Once launched, went through the following using 1.62.165 Chromium: 121.0.6167.184 on Win 11 x64

  • logged into the same account that was used above via https://account.bravesoftware.com/account/
  • once logged in, verified that Leo was a product that appeared as Purchased
    • ensured that Purchased on Android is visible/being displayed
  • clicked on Refresh Leo and ensured that new credentials were pulled and Leo switched to Premium on the desktop
  • ensured that Premium appeared throughout the UI and that Unlimited appeared next to each LLM (indicating Premium)
Example Example Example Example Example
desktopLinking1 desktopLinking2 desktopLinking3 desktopLinking4 desktopLinking5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link IAP on Android Leo
3 participants