Skip to content

Remove VPN services; only install after customer purchases (uplift to 1.63.x) #21680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Remove VPN services; only install after customer purchases (uplift to 1.63.x) #21680

wants to merge 3 commits into from

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 22, 2024 •
edited by bsclifton
Loading

Uplift of #20754
Fixes brave/brave-browser#33726

Uplift of #21762
Fixes brave/brave-browser#35590

Uplift of #21549
Fixes brave/brave-browser#35260

Also needs #21934 which is not done yet

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner January 22, 2024 17:43
@brave-builds brave-builds requested a review from a team January 22, 2024 17:43
@brave-builds brave-builds added this to the 1.63.x - Beta milestone Jan 22, 2024
@brave-builds brave-builds self-assigned this Jan 22, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 22, 2024
@bsclifton
Copy link
Member

I've manually tested this out on Nightly, so I checked the box. However, I know we usually have QA formally test before uplifting

@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@bsclifton bsclifton mentioned this pull request Jan 22, 2024
Closed
simonhong and others added 2 commits February 8, 2024 11:15
@simonhong @bsclifton
Merge pull request #21762 from brave/wg_default_prefs
20df120 
Updated Wireguard enabled state timing
@bsclifton
Merge pull request #21549 from brave/remove_install_static_deps_from_…
5a32f0a 
…vpn_component

Removed install_static deps from vpn component
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@bsclifton
Copy link
Member

One last PR would be needed (#21934) - but we're closely approaching the 1.63 ship date.

I'll keep this PR open for now in case we do a follow up release for 1.63. Otherwise, we can plan for the work landing in 1.64.

kjozwiak
kjozwiak reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing as we're going to let the VPN work ride the trains via 1.64.x as discussed via the weekly b-b planning/triage meeting.

@kjozwiak kjozwiak closed this Feb 14, 2024
@kjozwiak kjozwiak deleted the pr20754_bsc-windows-vpn-remove-services_1.63.x branch February 14, 2024 04:20
@kjozwiak kjozwiak removed this from the 1.63.x - Beta milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak left review comments

Assignees

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @bsclifton @kjozwiak @simonhong