Skip to content

Stats updater fixes #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 29, 2019
Merged

Stats updater fixes #2112

merged 4 commits into from
Mar 29, 2019

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Mar 28, 2019

Fix brave/brave-browser#3895

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • Start with a clean profile
  • Launch Brave and keep it running for duration of test
  • Verify that daily ping is sent on startup and looks accurate
  • Wait 6 minutes (pings are checked every 5 minutes, so this factors in a little wiggle room)
  • Set computer's clock ahead to the next day (or you could run this test at 11:55pm or so)
  • Verify that daily ping is sent for this "new" day and that it looks accurate

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@emerick emerick self-assigned this Mar 28, 2019
@emerick emerick requested review from bbondy and iefremov March 28, 2019 18:28
@emerick emerick merged commit c08710a into master Mar 29, 2019
@emerick emerick deleted the stats-updater-fixes branch March 29, 2019 17:55
@emerick emerick added this to the 0.64.x - Nightly milestone Mar 29, 2019
emerick added a commit that referenced this pull request Mar 30, 2019
emerick added a commit that referenced this pull request Mar 30, 2019
emerick added a commit that referenced this pull request Mar 30, 2019
Merge pull request #2112 from brave/stats-updater-fixes
emerick added a commit that referenced this pull request Mar 30, 2019
Merge pull request #2112 from brave/stats-updater-fixes
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Adds support for unified rewards flag
petemill pushed a commit that referenced this pull request Jul 27, 2020
Adds support for unified rewards flag
petemill pushed a commit that referenced this pull request Jul 28, 2020
Adds support for unified rewards flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats updater uses wrong timestamps
2 participants