[0.63.x] uplift request #2042 to dev(turn on crash report by default on beta)

[simonhong]

Uplift #2042 for dev channel

Turn on crash report by default on beta channel

[srirambv]

Approved after deliberating with @rebron. Please merge once the CI check is complete and update labels accordingly.

[simonhong]

Dev branch build is failed by below.

11:43:31  FAILED: obj/brave/vendor/bat-native-confirmations/bat-native-confirmations/redeem_token.o 
11:43:31  /Users/jenkins/jenkins/workspace/e-browser-build-pr_uplift_pr2042/src/brave/script/redirect-cc.py ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/brave/vendor/bat-native-confirmations/bat-native-confirmations/redeem_token.o.d -DBRAVE_CHROMIUM_BUILD -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DCHROMIUM_BUILD -D_LIBCPP_HAS_NO_ALIGNED_ALLOCATION -DCR_XCODE_VERSION=0920 -DCR_CLANG_REVISION=\"351477-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=349080 -DCR_LIBCXXABI_REVISION=347903 -D_LIBCPP_ENABLE_NODISCARD -D_LIBCPP_ABI_UNSTABLE -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DNO_CXXEXCEPTIONS=1 -I../../brave/chromium_src -I../.. -Igen -I../../brave/vendor/bat-native-confirmations/src -I../../brave/vendor/bat-native-confirmations/include -I../../third_party/boringssl/src/include -I../../third_party/re2/src -I../../brave/vendor/bat-native-ledger/include -I../../brave/vendor/bat-native-tweetnacl -I../../brave/vendor/challenge_bypass_ristretto_ffi/src -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -fcomplete-member-pointers -arch x86_64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-ignored-pragma-optimize -O2 -fno-omit-frame-pointer -gdwarf-2 -fno-standalone-debug -isysroot ../../../../../../../../Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -mmacosx-version-min=10.10.0 -fvisibility=hidden -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=c++14 -stdlib=libc++ -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fvisibility-inlines-hidden -c ../../brave/vendor/bat-native-confirmations/src/bat/confirmations/internal/redeem_token.cc -o obj/brave/vendor/bat-native-confirmations/bat-native-confirmations/redeem_token.o
11:43:31  ../../brave/vendor/bat-native-confirmations/src/bat/confirmations/internal/redeem_token.cc:175:33: error: no viable conversion from 'std::unique_ptr<Value>' to 'base::Optional<base::Value>'
11:43:31      base::Optional<base::Value> dictionary = base::JSONReader::Read(response);
11:43:31                                  ^            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
11:43:31  ../../base/optional.h:438:13: note: candidate constructor not viable: no known conversion from 'std::unique_ptr<Value>' to 'const base::Optional<base::Value> &' for 1st argument
11:43:31    constexpr Optional(const Optional& other) = default;
11:43:31              ^
11:43:31  ../../base/optional.h:439:13: note: candidate constructor not viable: no known conversion from 'std::unique_ptr<Value>' to 'base::Optional<base::Value> &&' for 1st argument
11:43:31    constexpr Optional(Optional&& other) noexcept(
11:43:31              ^
11:43:31  ../../base/optional.h:442:13: note: candidate constructor not viable: no known conversion from 'std::unique_ptr<Value>' to 'base::nullopt_t' for 1st argument
11:43:31    constexpr Optional(nullopt_t) {}  // NOLINT(runtime/explicit)
11:43:31              ^
11:43:31  ../../base/optional.h:454:3: note: candidate template ignored: could not match 'Optional' against 'unique_ptr'
11:43:31    Optional(const Optional<U>& other) : internal::OptionalBase<T>(other) {}
11:43:31    ^
11:43:31  ../../base/optional.h:473:3: note: candidate template ignored: could not match 'Optional' against 'unique_ptr'
11:43:31    Optional(Optional<U>&& other) : internal::OptionalBase<T>(std::move(other)) {}
11:43:31    ^
11:43:31  ../../base/optional.h:509:13: note: candidate template ignored: requirement 'std::is_constructible<base::Value, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> > &&>::value' was not satisfied [with U = std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >]
11:43:31    constexpr Optional(U&& value)
11:43:31              ^
11:43:31  1 error generated.

[yrliou]

@simonhong it is possible that it is caused by #2055 which is reverted in dev, I would suggest to kick off one again to see if it is resolved.

[simonhong]

@yrliou Yep! thanks :)