-
Notifications
You must be signed in to change notification settings - Fork 965
Revert unified adblock catalog #20442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -31,24 +31,27 @@ namespace { | |||
|
|||
typedef struct ListDefaultOverrideConstants { | |||
const raw_ref<const base::Feature> feature; | |||
const char* local_override_pref; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
[semgrep] raw_ptr should be used instead of T* in classes and structs (but not in local variables and function parameters).
References:
- https://groups.google.com/a/chromium.org/g/chromium-dev/c/vAEeVifyf78/m/SkBUc6PhBAAJ
- https://chromium.googlesource.com/chromium/src/+/refs/heads/main/base/memory/raw_ptr.md
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/client/chromium-raw-ptr.yaml
Cc @thypon @fmarier
Uplift of #20442 (squashed) to beta
Reverting because of major perf problem in the original PR. perf thread
For #19946
For #20284
For #20227
Resolves brave/brave-browser#33520
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: