[Android] display bookmark export file path #20366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarolin
reviewed
Oct 6, 2023
| @@ -1278,17 +1278,32 @@ This file contains all "about" strings. It is set to NOT be translated, in tran | |||
| <message name="IDS_IMPORT_BOOKMARKS_SELECT_FILE" desc="Import Bookmarks file chooser text"> | |||
| Select a File to Import bookmarks | |||
| </message> | |||
| <message name="IDS_IMPORT_BOOKMARKS_SUCCESS" desc="Import Bookmarks success text message."> | |||
| <message name="IDS_EXPORT_BOOKMARKS_SUCCESS_TITLE" desc="Export Bookmarks success title text."> | |||
| Export successful | |||
There was a problem hiding this comment.
Suggestion: Export succeeded (to match the opposite Export failed).
There was a problem hiding this comment.
@anthonypkeane wdyt?
mkarolin
reviewed
Oct 6, 2023
| Export successful | ||
| </message> | ||
| <message name="IDS_EXPORT_BOOKMARKS_SUCCESS_BODY" desc="Export Bookmarks success text message."> | ||
| Bookmarks exported to <ph name="EXPORT_FILE_PATH">%1$s<ex>/Download/bookmarks.html</ex></ph> |
There was a problem hiding this comment.
Suggestion: Exported bookmarks to <ph...
mkarolin
reviewed
Oct 6, 2023
| Export failed | ||
| </message> | ||
| <message name="IDS_EXPORT_BOOKMARKS_FAIL_BODY" desc="Export Bookmarks fail text message."> | ||
| Bookmarks export failed. Please try again. |
There was a problem hiding this comment.
Suggestion: Failed to export bookmarks...
mkarolin
reviewed
Oct 6, 2023
| Bookmarks export failed. Please try again. | ||
| </message> | ||
| <message name="IDS_IMPORT_BOOKMARKS_SUCCESS_TITLE" desc="Import Bookmarks success title text."> | ||
| Import successful |
There was a problem hiding this comment.
Suggestion: Export succeeded
mkarolin
reviewed
Oct 6, 2023
| <message name="IDS_IMPORT_BOOKMARKS_SUCCESS_TITLE" desc="Import Bookmarks success title text."> | ||
| Import successful | ||
| </message> | ||
| <message name="IDS_IMPORT_BOOKMARKS_SUCCESS_BODY" desc="Import Bookmarks success text message."> | ||
| Bookmarks imported successfully. |
There was a problem hiding this comment.
Suggestion: Imported bookmarks successfully.
mkarolin
reviewed
Oct 6, 2023
| <message name="IDS_EXPORT_BOOKMARKS_FAILED" desc="Export Bookmarks failed text message."> | ||
| Bookmark export failed. | ||
| <message name="IDS_IMPORT_BOOKMARKS_FAIL_BODY" desc="Import Bookmarks fail text message."> | ||
| Bookmark import failed. Please try again. |
There was a problem hiding this comment.
Suggestion: Failed to import bookmark(s?)...
mkarolin
approved these changes
Oct 6, 2023
tapanmodh
force-pushed
the
display_bookmark_export_file_path_android
branch
from
31d3da9 to
66c6ee2
Compare
tapanmodh
force-pushed
the
display_bookmark_export_file_path_android
branch
from
66c6ee2 to
7394b52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#33171
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
Open folderbutton to open the folder containing exported bookmarks