Skip to content

Fixes a crash on a tab back gesture on Android 14 #19766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Fixes a crash on a tab back gesture on Android 14 #19766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion patches/chrome-android-java-AndroidManifest.xml.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml
index 6f3722cd64029848c1737ced63889cf7cb41c5aa..b6cc02b81f52a5b27c04cd8b5fa7fdd0a9c8e0c6 100644
index 6f3722cd64029848c1737ced63889cf7cb41c5aa..7195ef1e5fc2c67861001a44e7070dea584fae62 100644
--- a/chrome/android/java/AndroidManifest.xml
+++ b/chrome/android/java/AndroidManifest.xml
@@ -28,6 +28,7 @@ by a child template that "extends" this file.
Expand Down Expand Up @@ -58,6 +58,15 @@ index 6f3722cd64029848c1737ced63889cf7cb41c5aa..b6cc02b81f52a5b27c04cd8b5fa7fdd0

{% block extra_uses_permissions %}
{% endblock %}
@@ -200,7 +213,7 @@ by a child template that "extends" this file.
android:networkSecurityConfig="@xml/network_security_config"
android:allowAudioPlaybackCapture="false"
android:appComponentFactory="org.chromium.chrome.browser.base.SplitCompatAppComponentFactory"
- android:enableOnBackInvokedCallback="true"
+ android:enableOnBackInvokedCallback="false"
{% block extra_application_attributes %}{% endblock %}>

{% if channel in ['canary', 'dev', 'default'] %}
@@ -349,6 +362,7 @@ by a child template that "extends" this file.
<intent-filter>
<action android:name="com.sec.android.airview.HOVER" />
Expand Down