Skip to content

Fix permission reset on page reopen during ES keep-alive. #18920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Conversation

goodov
Copy link
Member

@goodov goodov commented Jun 15, 2023

Permission cleanup event on tab close was incorrectly lost if the tab was reopened shortly after. This PR changes the way OnCleanupTLDEphemeralArea event is passed to PermissionOriginLifetimeMonitorImpl by implementing an observer instead of passing callbacks here and there.

Resolves brave/brave-browser#31072

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov self-assigned this Jun 15, 2023
@goodov goodov requested review from darkdh and iefremov June 15, 2023 10:09
@goodov goodov marked this pull request as ready for review June 15, 2023 10:11
@goodov goodov changed the title Fix permission reset on page reopen during keep-alive. Fix permission reset on page reopen during ES keep-alive. Jun 15, 2023
}

void EphemeralStorageService::CleanupTLDEphemeralArea(
const TLDEphemeralAreaKey& key,
bool cleanup_first_party_storage_area,
TLDEphemeralAreaOnDestroyCallbacks on_destroy_callbacks) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these callbacks was a hacky approach from the start. Observer implementation works better and is much cleaner.

@goodov goodov merged commit ccf0b54 into master Jun 16, 2023
@goodov goodov deleted the issues/31072 branch June 16, 2023 07:21
@github-actions github-actions bot added this to the 1.54.x - Nightly milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permission is not reset on page reopen if 30 seconds has not passed
2 participants