Implement additional ad event confirmations #1890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
reviewed
Mar 7, 2019
| int total_viewed = 0; | ||
|
|
||
| for (const auto& transaction : info->transactions) { | ||
| if (transaction.confirmation_type != "view") { |
There was a problem hiding this comment.
can we move this string into variable, so that we have it only in one place?
NejcZdovc
reviewed
Mar 7, 2019
| writer.String(time_stamp.c_str()); | ||
|
|
||
| writer.String("notificationId"); | ||
| writer.String(info.uuid.c_str()); | ||
|
|
||
| std::string type; | ||
| switch (info.type) { | ||
| case ConfirmationType::UNKNOWN: { |
There was a problem hiding this comment.
can we extract all this types into variable? (same as comment above)
NejcZdovc
reviewed
Mar 7, 2019
| @@ -71,6 +76,21 @@ Result NotificationInfo::FromJson( | |||
| uuid = document["uuid"].GetString(); | |||
| } | |||
|
|
|||
| if (document.HasMember("confirmation_type")) { | |||
| std::string confirmation_type = document["confirmation_type"].GetString(); | |||
| if (confirmation_type == "click") { | |||
NejcZdovc
reviewed
Mar 7, 2019
| break; | ||
| } | ||
|
|
||
| case ConfirmationType::CLICK: { |
NejcZdovc
reviewed
Mar 7, 2019
| break; | ||
| } | ||
|
|
||
| case ConfirmationType::CLICK: { |
NejcZdovc
reviewed
Mar 7, 2019
| break; | ||
| } | ||
|
|
||
| case ConfirmationType::CLICK: { |
tmancey
force-pushed
the
issues/3587
branch
2 times, most recently
from
a808b3e to
b416870
Compare
tmancey
force-pushed
the
issues/3587
branch
2 times, most recently
from
5518141 to
8f460b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes brave/brave-browser#3587
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: