Skip to content

Custodian mismatch message #18871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

sujitacharya2005
Copy link
Contributor

@sujitacharya2005 sujitacharya2005 commented Jun 12, 2023

Resolves brave/brave-browser#30935
Resolves brave/brave-browser#30936

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Step1 Clean profile v1.47.16 nightly build Enable rewards and claim UGP grants Screenshot_20230613_001244
Step2 Update Latest nightly from play store 1.54.48 & open github.com/miyayes , Issue here shows custodian mismatch message Screenshot_20230613_001814
Step3 update local fixed apk 1.54.54 Now it will not show custodian mismatch message, now you can tip without unconnected state in grandfather state Screenshot_20230613_005513

@sujitacharya2005 sujitacharya2005 added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-all-linters Do not run linters and presubmit checks labels Jun 12, 2023
Copy link
Contributor

@tapanmodh tapanmodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sujitacharya2005 sujitacharya2005 force-pushed the 30935_custodian_mismatch_message branch from 7875bf1 to 3e7cca7 Compare June 14, 2023 04:29
@sujitacharya2005 sujitacharya2005 merged commit 99749da into master Jun 14, 2023
@sujitacharya2005 sujitacharya2005 deleted the 30935_custodian_mismatch_message branch June 14, 2023 05:35
@github-actions github-actions bot added this to the 1.54.x - Nightly milestone Jun 14, 2023
brave-builds added a commit that referenced this pull request Jun 17, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 21, 2023

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.55.2

Issue #30936_PASSED
1.47.97 1.55.2 1.55.2
Screenshot_20230621-224352_Brave - Nightly Screenshot_20230621-224454_Brave - Nightly Screenshot_20230621-224541_Brave - Nightly
Issue #30935_PASSED
Example Example
Screenshot_20230621-224731_Brave - Nightly Screenshot_20230621-224757_Brave - Nightly

kjozwiak pushed a commit that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-all-linters Do not run linters and presubmit checks CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
4 participants