Skip to content

Hide rewards menu for unsupported countries #17482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#28908

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 6, 2023
@deeppandya deeppandya added this to the 1.51.x - Nightly milestone Mar 6, 2023
@deeppandya deeppandya requested a review from mkarolin March 6, 2023 11:30
@deeppandya deeppandya self-assigned this Mar 6, 2023
@deeppandya deeppandya added CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-linux-arm64 labels Mar 7, 2023
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deeppandya deeppandya force-pushed the remove_rewards_menu_unsupported_countries branch from 1cf41bc to 747b197 Compare March 8, 2023 16:52
@deeppandya deeppandya merged commit cfd0b96 into master Mar 8, 2023
@deeppandya deeppandya deleted the remove_rewards_menu_unsupported_countries branch March 8, 2023 19:10
brave-builds added a commit that referenced this pull request Mar 8, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 16, 2023

Verification PASSED on Samsung Galaxy Version 12 running Bravemonoarm64.apk_1.51.37

Russia

Example Example
Screenshot_20230316-151322_Settings Screenshot_20230316-151248_Brave - Nightly

kjozwiak pushed a commit that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] The Brave Rewards option is shown in the 3 dot menu for the brave rewards unavailable countries
4 participants