Skip to content

Fix asset discovery for cUSDT #17403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2023
Merged

Fix asset discovery for cUSDT #17403

merged 2 commits into from
Feb 28, 2023

Conversation

nvonpentz
Copy link
Contributor

When checking if a BalanceScanner result is > 0 for asset discovery, convert the balance to an integer instead of doing a string comparison.

Resolves brave/brave-browser#28752

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Verify Compound Tether should is not discovered automatically unless you actually own that asset. Other assets should still be discovered.

@nvonpentz
Fix asset discovery for cUSDT
b283cfb 
When checking if a BalanceScanner result is > 0 for asset discovery,
convert the balance to an integer instead of doing a string comparison.
@nvonpentz nvonpentz requested a review from a team as a code owner February 27, 2023 20:46
yrliou
yrliou reviewed Feb 27, 2023
View reviewed changes
components/brave_wallet/browser/asset_discovery_manager.cc Outdated
contract_addresses[i]);
if (balance_results[i]->balance.has_value()) {
uint256_t balance_uint;
HexValueToUint256(balance_results[i]->balance.value(), &balance_uint);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function might fail.

@nvonpentz nvonpentz merged commit 0856f30 into master Feb 28, 2023
@nvonpentz nvonpentz deleted the fix-cusdt-asset-discovery branch February 28, 2023 00:56
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 28, 2023
@srirambv srirambv mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrliou yrliou yrliou approved these changes

Assignees

@nvonpentz nvonpentz

Labels
None yet
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging this pull request may close these issues.

cUSDT is autodiscovered even when the user does not hold it
2 participants
@nvonpentz @yrliou