Skip to content

Renamed Bookmark -> Bookmarks #17274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2023
Merged

Renamed Bookmark -> Bookmarks #17274

merged 1 commit into from
Feb 18, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 17, 2023

Resolves brave/brave-browser#28590

image

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • steps from the issue

@spylogsster spylogsster merged commit 0e38d48 into master Feb 18, 2023
@spylogsster spylogsster deleted the brave-28590 branch February 18, 2023 11:23
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 18, 2023
@spylogsster spylogsster restored the brave-28590 branch February 21, 2023 17:06
brave-builds added a commit that referenced this pull request Feb 21, 2023
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.50.54 Chromium: 110.0.5481.104 (Official Build) nightly (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Windows 10 Version 22H2 (Build 19045.2604)

Steps:

  1. installed 1.50.54
  2. launched Brave
  3. opened brave://settings/appearance
  4. checked descriptive text for Show bookmarks options

Confirmed it reads Bookmarks bar correctly, in all places

Never Always Only on the new tab page
image image image

kjozwiak pushed a commit that referenced this pull request Feb 22, 2023
@spylogsster spylogsster deleted the brave-28590 branch May 16, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookmark bar should be Bookmarks bar in brave://settings/appearance
3 participants