Skip to content

Fix panel header overflow on Rewards page #17124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Feb 9, 2023

Resolves brave/brave-browser#28403

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Before change

Screen Shot 2023-02-09 at 11 36 34 AM

After change

Screen Shot 2023-02-09 at 11 38 17 AM

@zenparsing zenparsing requested a review from a team as a code owner February 9, 2023 16:05
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

⚠️ PR head is an unsigned commit
commit: 321dc65d7f9ec6d8192008760c3ee4f56f113312
reason: unsigned
Please follow the handbook to configure commit signing
cc: @zenparsing

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

⚠️ PR head is an unsigned commit
commit: 321dc65d7f9ec6d8192008760c3ee4f56f113312
reason: unsigned
Please follow the handbook to configure commit signing
cc: @zenparsing

@zenparsing zenparsing force-pushed the ksmith-rewards-page-flex branch from 321dc65 to 3b37803 Compare February 9, 2023 16:38
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@zenparsing zenparsing merged commit ff7d33b into master Feb 9, 2023
@zenparsing zenparsing deleted the ksmith-rewards-page-flex branch February 9, 2023 21:18
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 9, 2023
brave-builds added a commit that referenced this pull request Feb 9, 2023
brave-builds added a commit that referenced this pull request Feb 9, 2023
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 5G using version:

Brave	1.50.28 Chromium: 110.0.5481.77 (Official Build) canary (32-bit) 
Revision	65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS	Android 13; Build/TP1A.220624.014
  • Ensured that brave://rewards page displays correctly in non-US locale
  • Ensured that header does not overflow on the page
Example Example
screenshot-1676066921840 screenshot-1676066949865

kjozwiak pushed a commit that referenced this pull request Feb 13, 2023
kjozwiak pushed a commit that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misalignment issue on rewards page for non us locales
4 participants