Skip to content

Revert removing widgets [Uplift to 1.48.x] #16906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2023
Merged

Revert removing widgets [Uplift to 1.48.x] #16906

merged 1 commit into from
Jan 29, 2023

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Jan 28, 2023 •
edited by kjozwiak
Loading

Uplift of #16904
Resolves brave/brave-browser#28118

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added this to the 1.48.x - Beta milestone Jan 28, 2023
@deeppandya deeppandya requested a review from a team as a code owner January 28, 2023 20:31
@deeppandya deeppandya self-assigned this Jan 28, 2023
@deeppandya deeppandya changed the title Revert removing widgets Revert removing widgets [Uplift to 1.48.x] Jan 28, 2023
@SergeyZhukovsky SergeyZhukovsky added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 28, 2023
kjozwiak
kjozwiak approved these changes Jan 29, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.48.x approved 👍 QA has verified the PR on Nightly as per #16904 (comment).

@kjozwiak kjozwiak merged commit 9f855b0 into 1.48.x Jan 29, 2023
@kjozwiak kjozwiak deleted the revert_widgets_removal_1.48.x branch January 29, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@deeppandya @kjozwiak @SergeyZhukovsky