Skip to content

Added Microsoft IE #16800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Added Microsoft IE #16800

merged 1 commit into from
Jan 24, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jan 23, 2023

Resolves brave/brave-browser#27557

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • go to brave://welcome page when Microsoft Internet explorer installed, windows
  • check it has correct icon and name

@spylogsster spylogsster self-assigned this Jan 23, 2023
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 23, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@nullhook nullhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spylogsster spylogsster merged commit 782bc9b into master Jan 24, 2023
@spylogsster spylogsster deleted the brave-27557 branch January 24, 2023 14:05
@spylogsster spylogsster added this to the 1.49.x - Nightly milestone Jan 24, 2023
@github-actions github-actions bot added this to the 1.49.x - Nightly milestone Jan 24, 2023
@spylogsster spylogsster restored the brave-27557 branch January 24, 2023 17:56
spylogsster added a commit that referenced this pull request Jan 24, 2023
spylogsster added a commit that referenced this pull request Jan 31, 2023
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.49.75 Chromium: 110.0.5481.52 (Official Build) nightly (64-bit)
-- | --
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Windows 11 Version 22H2 (Build 22621.1105)

Verified the IE was using the correct icon and wasn't being selected as the default browser as per the STR/Cases outlined via #16800 (comment) & brave/brave-browser#27557 (comment).

Light Mode

Example Example
ieLight ieLightCheck

Dark Mode

Example Example
ieDark ieDarkCheck

kjozwiak pushed a commit that referenced this pull request Jan 31, 2023
@spylogsster spylogsster deleted the brave-27557 branch May 16, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chromium- based browser shown on Import Settings screen
4 participants