feat(wallet): Advanced Solana NFT gallery support (frontend desktop changes) #16276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion_decoder to new solana_data_decoder_utils
Also: * Add missing return JsonRpcService::GetMetaplexMetadata * Add addition test to solana data decoder utils unittest
Instead of constantly casing on an CoinType argument to choose the correct error (ProviderError or SolanaProviderError), use an integer value and cast at the end.
* Make it clear which function is for SOL and ETH by reading the function name alone * Rename FetchMetadataToken to FetchMetadata which is slightly more intuitive
* Revert "Address feedback: Separate some decode functions from solana_instruction_decoder to new solana_data_decoder_utils" (af24b30). * Guards against out of bounds access in DecodeMetadataUri and add a test for that case * Do not use reinterpret_cast
* Remove unused solana_instruction_data_decoder.h heade in
json_rpc_service.cc
* Rename functions
- JsonRpcService::OnGetTokenUri2 -> JsonRpcService::OnGetEthTokenUri
- NftMetadataFetcher::OnGetTokenUriTokenMetadata
-> NftMetadataFetcher::JsonRpcService::OnGetEthTokenUri
- NftMetadataFetcher::OnGetSupportsInterfaceTokenMetadata
-> NftMetadataFetcher::OnGetSupportsInterface
* Reorganize functions in nft_metadata_fetcher.h
* Remove VLOG(0) debug line in json_rpc_service_unittest.cc
* Revert change to SetInterceptor() in json_rpc_service_unittest.cc that
is no longer relevant
* Add comment explaining GetTokenMetadataIntermediateCallback purpose
* Remove commented code in nft_metadata_fetcher_unittest.cc
* Remove unused import added to solana_instruction_data_decoder_unittest.cc
* Resolve TODO comment by adding missing GetEthTokenUri test case
* Rename nft_account_address -> token_mint_address * Add comment with link to documentation for deriving nft metadata accounts * Revert change: continue using kInvalidParams instead of kInternalError in the case that the network URL is invalid for JsonRpcService::GetEthTokenUri * Do not call std::move() on when passing error type * Do not use a const reference for metadata seed constant string * Make sure the int error value is valid before sending via mojo * Use "base::Base64Decode(account_info->data)" syntax since it's easier to read * Use const reference for vector of bytes input to NftMetadataFetcher::DecodeMetadataUri function * Move DecodeUint32 in anonymous namespace in c++ instead of a member function
github-actions
bot
added
the
CI/storybook-url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#27129
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
Solana.NFT.Metadata.mov