-
Notifications
You must be signed in to change notification settings - Fork 1k
Added BraveVPN Windows service for setting DNS filters #15915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fb99aec
to
df2a42e
Compare
52c29c4
to
be02a20
Compare
5212180
to
7ffe672
Compare
components/brave_vpn/browser/connection/win/brave_vpn_helper/brave_vpn_helper_state.cc
Outdated
Show resolved
Hide resolved
components/brave_vpn/browser/connection/win/brave_vpn_helper/brave_vpn_helper_state.cc
Show resolved
Hide resolved
38000f4
to
dfb50c5
Compare
components/brave_vpn/browser/connection/win/brave_vpn_helper/vpn_dns_handler.cc
Outdated
Show resolved
Hide resolved
f44509b
to
f3d3c69
Compare
… or failed to start
f3d3c69
to
dc35396
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! 😄👍
I can help get the final text updated before we ship
process_type); | ||
if (process_type == crash_reporter::switches::kCrashpadHandler) { | ||
// Check if we should monitor the exit code of this process | ||
std::unique_ptr<browser_watcher::ExitCodeWatcher> exit_code_watcher; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is default initialising exit_code_watcher
to nullptr. However, a few lines down we check for the validity of exit_code_watcher
, which will always return false, so it won't ever call exit_code_watcher->StopWatching();
.
Do we need this browser_watcher::ExitCodeWatcher
instance here?
Resolves brave/brave-browser#25489
Sec review and video in https://github.com/brave/security/issues/1029
%channel%\User Data\Crashpad\reports
netsh wfp show filters
Helper's crash reports:

Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: