-
Notifications
You must be signed in to change notification settings - Fork 966
Add redirect modal for provider unavailable scenario #15627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redirect modal for provider unavailable scenario #15627
Conversation
A Storybook has been deployed to preview UI for the latest push |
Hey @emerick, 🙂 |
{ | ||
"message": "Error validating Connecting Brave Rewards to Uphold is temporarily unavailable. Please try again later", | ||
"code": 400 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just ran into this myself 😄, this is what we get back:
{
"code": 400,
"data": {
"validationErrors": null
},
"message": "Error validating Connecting Brave Rewards to Uphold is temporarily unavailable. Please try again later"
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
SonarCloud failed due to a known code-duplication warning in our redirect modal code. Outside of that, CI passed on all platforms so this is ready for merge. |
Resolves brave/brave-browser#25125
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
UI
Test Plan: