Skip to content

Desktop VPN Panel support view validation UI (uplift to 1.45.x) #15570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Desktop VPN Panel support view validation UI (uplift to 1.45.x) #15570

wants to merge 1 commit into from

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 20, 2022 •
edited by bsclifton
Loading

Uplift of #15555
Resolves brave/brave-browser#25860

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner October 20, 2022 16:16
@brave-builds brave-builds self-assigned this Oct 20, 2022
@brave-builds brave-builds added this to the 1.45.x - Release milestone Oct 20, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 20, 2022
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@kjozwiak
Copy link
Member

We'll get the above uplifted/merged once 1.45.x goes out on Oct. 25, 2022 as VPN is slated for either the 1.45.x maintenance release or 1.46.x.

@bsclifton bsclifton removed this from the 1.45.x - Release #4 milestone Oct 28, 2022
@bsclifton
Copy link
Member

Closing as we pushing VPN feature in the 1.45.x maintenance release is way too tight at this point

@bsclifton bsclifton closed this Oct 28, 2022
@bsclifton bsclifton deleted the pr15555_vpn-desktop-support-validation_1.45.x branch October 28, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @bsclifton @brave-browser-releases