Skip to content

Use chromium language list by default #15433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Oct 12, 2022

For brave/brave-browser#24303

The translate.brave.com will soon support the other language pair.
Here is PR to revert build-in language list to chromium one. That list is the same that translate.brave.com supports.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@atuchin-m atuchin-m marked this pull request as ready for review October 12, 2022 11:35
@atuchin-m atuchin-m requested a review from a team as a code owner October 12, 2022 11:35
@atuchin-m
Copy link
Collaborator Author

@linhkikuchi please approve after the prod backend is ready.

@atuchin-m atuchin-m merged commit 2da3f4c into master Oct 14, 2022
@atuchin-m atuchin-m deleted the use-chromium-language-list-by-default branch October 14, 2022 15:20
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Oct 14, 2022
@atuchin-m atuchin-m restored the use-chromium-language-list-by-default branch October 14, 2022 16:26
brave-builds pushed a commit that referenced this pull request Oct 14, 2022
@atuchin-m atuchin-m deleted the use-chromium-language-list-by-default branch October 14, 2022 17:22
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.46.60 Chromium: 107.0.5304.36 (Official Build) nightly (64-bit)
-- | --
Revision | 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS | Windows 11 Version 22H2 (Build 22621.674)

Ensured that all the remaining languages were being listed via brave://translate-internals as per the STR/Cases outlined via brave/brave-browser#24303 (comment).

1.44.112 Chromium: 106.0.5249.119 1.46.60 Chromium: 107.0.5304.36
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants