Skip to content

feat(wallet): charge Jupiter fees for selective output mints #15248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

onyb
Copy link
Member

@onyb onyb commented Sep 27, 2022

Resolves brave/brave-browser#25657

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See linked issue

@onyb onyb self-assigned this Sep 27, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 27, 2022
@onyb onyb marked this pull request as ready for review September 27, 2022 21:17
@onyb onyb requested a review from a team as a code owner September 27, 2022 21:17
@onyb onyb force-pushed the f/wallet/jupiter-fees branch 3 times, most recently from 8400eb2 to ef5015f Compare September 28, 2022 02:21
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@onyb onyb force-pushed the f/wallet/jupiter-fees branch from ef5015f to 376c2f1 Compare September 30, 2022 03:32
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@srirambv
Copy link
Contributor

srirambv commented Oct 6, 2022

Verification passed on

Brave 1.46.35 Chromium: 106.0.5249.91 (Official Build) nightly (64-bit)
Revision fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS Windows 11 Version 22H2 (Build 22623.730)
  • Verified Swap fee is only collected for selected tokens
Swap Transaction Fees
SOL -> USDT Tx Hash image
USDT -> SOL Tx Hash image
SHDW -> SOL Tx Hash image
SHDW -> USDC Tx Hash image
SOL -> SHDW Tx Hash image
USDC -> SHDW Tx Hash image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Jupiter fees only for selected output mints
4 participants