Skip to content

Fix payment status link in WebUI Rewards panel #15018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Sep 7, 2022

Resolves brave/brave-browser#25253
Resolves brave/brave-browser#25223

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

The following conditions must be met in order for the UI to be seen:

  • The rewards /parameters endpoint must return a payout status of "processing" for user's current wallet type.
  • The local machine date should be past the environment payout date (likely the 7th or later).
  • The user must have ad rewards for the previous month.

See #14063 (comment) for related test steps and screenshots of affected UI.

@zenparsing zenparsing requested a review from a team as a code owner September 7, 2022 15:38
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 7, 2022
@zenparsing zenparsing removed the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 7, 2022
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing merged commit 85ad363 into master Sep 7, 2022
@zenparsing zenparsing deleted the ksmith-check-status-link branch September 7, 2022 19:22
@github-actions github-actions bot added this to the 1.45.x - Nightly milestone Sep 7, 2022
brave-builds pushed a commit that referenced this pull request Sep 7, 2022
brave-builds pushed a commit that referenced this pull request Sep 7, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Sep 8, 2022

Verified with

Brave | 1.45.34 Chromium: 105.0.5195.102 (Official Build) nightly (x86_64)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | macOS Version 12.5.1 (Build 21G83)

Case 1: brave/brave-browser#25253

Unverified - PASSED

Using conditions mentioned in #15018 (comment) as a guide,

  • had at least one ad cashed in with the server (redeemed) for September prior to end of month
  • had Charles Proxy rules set up to return "processing", "complete", and "off" as needed
  1. Advanced device date to Oct 6th (day before payout), launched and confirmed "countdown" message displayed
  2. Closed Brave
  3. Enabled Charles Proxy rule so that "processing" was returned
  4. Advanced device date to Oct 7th (payout day), launched and confirmed "processing" message displayed
  5. Confirmed "Check status" link works from webUI panel (ensure proper study, BraveRewardsWebUiPanelStudy:Enabled, is shown on brave://version before checking)
  6. Closed Brave
  7. Disabled Charles Proxy rule for "processing", and Enabled Charles Proxy rule so that "complete" was returned
  8. Launched and confirmed "complete" message is displayed
  9. Closed Brave
  10. Disabled Charles Proxy rule for "complete", and Enabled Charles Proxy rule so that "off" was returned
  11. Launched and confirmed no banner UI is displayed
Step 1 Step 4 Step 5 Step 8 Step 11
1 4 5 8 11
Uphold - SKIPPED

Skipped Uphold checks due to error in response from Uphold sandbox. Due to this error, unable to link on staging/sandbox env.

Gemini - PASSED

Using conditions mentioned in #15018 (comment) as a guide,

  • had at least one ad cashed in with the server (redeemed) for September prior to end of month
  • had Charles Proxy rules set up to return "processing", "complete", and "off" as needed
  1. Advanced device date to Oct 6th (day before payout), launched and confirmed "countdown" message displayed
  2. Closed Brave
  3. Enabled Charles Proxy rule so that "processing" was returned
  4. Advanced device date to Oct 7th (payout day), launched and confirmed "processing" message displayed
  5. Confirmed "Check status" link works from webUI panel (ensure proper study, BraveRewardsWebUiPanelStudy:Enabled, is shown on brave://version before checking)
  6. Closed Brave
  7. Disabled Charles Proxy rule for "processing", and Enabled Charles Proxy rule so that "complete" was returned
  8. Launched and confirmed "complete" message is displayed
  9. Closed Brave
  10. Disabled Charles Proxy rule for "complete", and Enabled Charles Proxy rule so that "off" was returned
  11. Launched and confirmed no banner UI is displayed
Step 1 Step 4 Step 5 Step 8 Step 11
1 4 5 8 11
bitFlyer - PASSED

Pre-req: have region = Japan

Using conditions mentioned in #15018 (comment) as a guide,

  • had at least one ad cashed in with the server (redeemed) for September prior to end of month
  • had Charles Proxy rules set up to return "processing", "complete", and "off" as needed
  1. Advanced device date to Oct 6th (day before payout), launched and confirmed "countdown" message displayed
  2. Closed Brave
  3. Enabled Charles Proxy rule so that "processing" was returned
  4. Advanced device date to Oct 7th (payout day), launched and confirmed "processing" message displayed
  5. Confirmed "Check status" link works from webUI panel (ensure proper study, BraveRewardsWebUiPanelStudy:Enabled, is shown on brave://version before checking)
  6. Closed Brave
  7. Disabled Charles Proxy rule for "processing", and Enabled Charles Proxy rule so that "complete" was returned
  8. Launched and confirmed "complete" message is displayed
  9. Closed Brave
  10. Disabled Charles Proxy rule for "complete", and Enabled Charles Proxy rule so that "off" was returned
  11. Launched and confirmed no banner UI is displayed
Step 1 Step 4 Step 5 Step 8 Step 11
1 4 5 8 11

Case 2: brave/brave-browser#25223

Reproduced the issue with 1.43.88 and webUI panel enabled, used STR from brave/brave-browser#25223. Clicking on the "Learn more" link did nothing.

Verified resolved with 1.45.34 and STR from brave/brave-browser#25223. Checked "Learn more" link for an unverified creator and a creator who had a different custodial wallet than the one used for Rewards (custodian has Uphold KYC'd wallet, Reward was using Gemini KYC'd custodial wallet).

Example Example Example Example Example
Screen Shot 2022-09-08 at 11 16 46 AM Screen Shot 2022-09-08 at 11 17 05 AM Screen Shot 2022-09-08 at 11 17 22 AM Screen Shot 2022-09-08 at 11 20 34 AM Screen Shot 2022-09-08 at 11 21 19 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Payment status link does not work in Rewards WebUI panel Unverified creator "Learn more" hyperlink does not work
4 participants