-
Notifications
You must be signed in to change notification settings - Fork 971
Fix payment status link in WebUI Rewards panel #15018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verified with
Case 1: brave/brave-browser#25253 Unverified - PASSEDUsing conditions mentioned in #15018 (comment) as a guide,
Uphold - SKIPPEDSkipped Uphold checks due to error in response from Uphold sandbox. Due to this error, unable to link on staging/sandbox env. Gemini - PASSEDUsing conditions mentioned in #15018 (comment) as a guide,
bitFlyer - PASSEDPre-req: have region = Japan Using conditions mentioned in #15018 (comment) as a guide,
Case 2: brave/brave-browser#25223 Reproduced the issue with 1.43.88 and webUI panel enabled, used STR from brave/brave-browser#25223. Clicking on the "Learn more" link did nothing. Verified resolved with 1.45.34 and STR from brave/brave-browser#25223. Checked "Learn more" link for an unverified creator and a creator who had a different custodial wallet than the one used for Rewards (custodian has Uphold KYC'd wallet, Reward was using Gemini KYC'd custodial wallet).
|
Resolves brave/brave-browser#25253
Resolves brave/brave-browser#25223
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
The following conditions must be met in order for the UI to be seen:
/parameters
endpoint must return a payout status of "processing" for user's current wallet type.See #14063 (comment) for related test steps and screenshots of affected UI.