Skip to content

Allow selecting rpc url #14104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2022
Merged

Allow selecting rpc url #14104

merged 2 commits into from
Aug 19, 2022

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented Jul 11, 2022 •
edited
Loading

Resolves brave/brave-browser#20516

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Desktop now allows selecting active rpc endpoint. Please also test upgrading from previous versions.
Also test android works as before(no active endpoint feature here and should not get broken)

bandicam.2022-07-18.16-14-41-574.mp4

@supermassive supermassive requested a review from a team as a code owner July 11, 2022 11:28
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jul 11, 2022
@supermassive supermassive force-pushed the SelectRpcUrl branch 2 times, most recently from 1f320c9 to d6155ca Compare July 14, 2022 05:25
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive requested a review from a team as a code owner July 14, 2022 07:18
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive force-pushed the SelectRpcUrl branch 2 times, most recently from 5772ddb to e7f2552 Compare July 14, 2022 08:18
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive force-pushed the SelectRpcUrl branch 2 times, most recently from bf366c0 to 011d294 Compare July 14, 2022 09:26
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive changed the title [WiP] Allow selecting rpc url Allow selecting rpc url Jul 18, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

kylehickinson
kylehickinson approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS++, not sure how it worked before

@kylehickinson kylehickinson requested a review from a team July 18, 2022 14:43
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive mentioned this pull request Aug 9, 2022
Closed
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@yrliou yrliou requested a review from SergeyZhukovsky August 16, 2022 22:11
@yrliou
Copy link
Member

yrliou commented Aug 16, 2022

Added @SergeyZhukovsky for android review.

SergeyZhukovsky
SergeyZhukovsky approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

android part++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive merged commit 5bc7bc5 into master Aug 19, 2022
@supermassive supermassive deleted the SelectRpcUrl branch August 19, 2022 09:48
@github-actions github-actions bot added this to the 1.44.x - Nightly milestone Aug 19, 2022
@srirambv srirambv mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

@yrliou yrliou yrliou approved these changes

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

Assignees

@supermassive supermassive

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.44.x - Release
Development

Successfully merging this pull request may close these issues.

Allow selecting which custom URL is the active RPC URL
5 participants
@supermassive @brave-builds @yrliou @kylehickinson @SergeyZhukovsky