Skip to content

WebTorrent styling #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2019
Merged

WebTorrent styling #1406

merged 1 commit into from
Jan 25, 2019

Conversation

rossmoody
Copy link
Contributor

@rossmoody rossmoody commented Jan 21, 2019 •
edited by bsclifton
Loading

Fixes brave/brave-browser#3034

This PR is meant to serve as very base formatting update to address only the breaking parts of this page in lieu of a proper spec. The main updates:

  1. Made page generally responsive so it doesn't break when sized down or when a long torrent title is surfaced.
  2. Added copy to make the user aware there is a way to disable this feature in settings.
  3. Small copy tweaks and amendments where ' elements were being pulled in.
  4. Added an animated loading icon

Before

screen shot 2019-01-21 at 11 30 40 am

After

screen shot 2019-01-21 at 11 32 45 am

Test plan

  1. Visit https://webtorrent.io/free-torrents
  2. Open one of the demo URLs (the torrent link)
  3. Start torrenting page shows
  4. Resize the page a bit; make sure it responds properly

@rossmoody rossmoody self-assigned this Jan 21, 2019
@rossmoody rossmoody added this to the 0.60.x - Dev milestone Jan 22, 2019
@rossmoody rossmoody mentioned this pull request Jan 24, 2019
Closed
@bsclifton bsclifton force-pushed the wt-styling branch 4 times, most recently from 03d8d7c to a6e1055 Compare January 25, 2019 08:32
@bsclifton
WebTorrent styling
ad41b48 
Test fixes

Linter/Formatting Fixes
bsclifton
bsclifton approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Works as expected 👍

@bsclifton bsclifton merged commit 4d7c3ff into master Jan 25, 2019
@bsclifton bsclifton deleted the wt-styling branch January 25, 2019 18:12
bsclifton added a commit that referenced this pull request Jan 25, 2019
@bsclifton
Merge pull request #1406 from brave/wt-styling
dab0214 
WebTorrent styling
bsclifton added a commit that referenced this pull request Jan 25, 2019
@bsclifton
Merge pull request #1406 from brave/wt-styling
541be8e 
WebTorrent styling
@bsclifton bsclifton mentioned this pull request Jan 25, 2019
Merged
@bsclifton bsclifton mentioned this pull request Jan 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@petemill petemill Awaiting requested review from petemill

@cezaraugusto cezaraugusto Awaiting requested review from cezaraugusto

@yrliou yrliou Awaiting requested review from yrliou

@bradleyrichter bradleyrichter Awaiting requested review from bradleyrichter

@rebron rebron Awaiting requested review from rebron

Assignees

@rossmoody rossmoody

Labels
None yet
Projects
None yet
Milestone
0.60.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@rossmoody @bsclifton