Skip to content

Reenable sol dapps by default #13994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Reenable sol dapps by default #13994

merged 1 commit into from
Jun 28, 2022

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Jun 28, 2022

Resolves brave/brave-browser#23520

First landed in #13825
Reverted in #13981

After the refactor, there should be no renderer crash

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Test plan in #13825

@darkdh darkdh requested a review from a team as a code owner June 28, 2022 20:54
@darkdh darkdh self-assigned this Jun 28, 2022
@darkdh darkdh changed the base branch from master to solana-provider-refactor June 28, 2022 20:54
Base automatically changed from solana-provider-refactor to master June 28, 2022 21:05
@darkdh darkdh merged commit 924e0fd into master Jun 28, 2022
@darkdh darkdh deleted the reenable-sol-dapps-by-default branch June 28, 2022 23:25
@github-actions github-actions bot added this to the 1.42.x - Nightly milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Solana DApps support by default on desktop
2 participants