Skip to content

Updated ecosia brand image #13745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Updated ecosia brand image #13745

merged 1 commit into from
Jun 14, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jun 13, 2022

fix brave/brave-browser#23405

Resolves

Screenshot_20220613-231630

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Set android region that ecosia is in default provider list (See below note for ecosia regions)
  2. Do fresh install and launch and first touch to omnibox shows search engine on boarding page
  3. Check ecosia uses latest brand logo

Note:
According to the source code(https://github.com/brave/brave-core/blob/master/chromium_src/components/search_engines/template_url_prepopulate_data.cc#L91),
below regions code include ecosia as one of the default provider.

  • AU(austrailia), IE(ireland), AT(austria), BE(belgium) and etc...

@simonhong simonhong requested a review from deeppandya June 13, 2022 04:44
@simonhong simonhong self-assigned this Jun 13, 2022
@simonhong simonhong added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jun 13, 2022
@simonhong
Copy link
Member Author

@deeppandya do you know where this image is used? curious how to test this update.

@deeppandya
Copy link
Contributor

@deeppandya do you know where this image is used? curious how to test this update.

@simonhong you can see the images in search engine onboarding.

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong
Copy link
Member Author

@deeppandya do you know where this image is used? curious how to test this update.

@simonhong you can see the images in search engine onboarding.

@deeppandya can you share how to see that onboarding page?

@simonhong simonhong merged commit d9bac0f into master Jun 14, 2022
@simonhong simonhong deleted the update_ecosia_brand_image branch June 14, 2022 06:29
@simonhong simonhong added this to the 1.41.x - Nightly milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update brand logo for Ecosia
2 participants