Skip to content

Disable goma localhost HTTP2 proxy. (uplift to 1.36.x) #12680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Disable goma localhost HTTP2 proxy. (uplift to 1.36.x) #12680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build/commands/lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,9 @@ const util = {
assert(fs.existsSync(compiler_proxy_binary), 'compiler_proxy not found at ' + config.gomaDir)
options.env.GOMA_COMPILER_PROXY_BINARY = compiler_proxy_binary

// Disable HTTP2 proxy. According to EngFlow this has significant performance impact.
options.env.GOMACTL_USE_PROXY = 0

// This skips the auth check and make this call instant if compiler_proxy is already running.
// If compiler_proxy is not running, it will fail to start if no valid credentials are found.
options.env.GOMACTL_SKIP_AUTH = 1
Expand Down