Skip to content

Disable goma localhost HTTP2 proxy. #12649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Disable goma localhost HTTP2 proxy. #12649

merged 1 commit into from
Mar 17, 2022

Conversation

goodov
Copy link
Member

@goodov goodov commented Mar 17, 2022

Resolves brave/brave-browser#21731

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov requested a review from mihaiplesa March 17, 2022 10:28
@goodov goodov requested a review from bridiver as a code owner March 17, 2022 10:28
@goodov goodov added this to the 1.38.x - Nightly milestone Mar 17, 2022
@mihaiplesa mihaiplesa added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 17, 2022
@github-actions github-actions bot removed the rebase label Mar 17, 2022
@mihaiplesa mihaiplesa removed CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 17, 2022
@mihaiplesa mihaiplesa merged commit f4f2250 into master Mar 17, 2022
@mihaiplesa mihaiplesa deleted the issues/21731 branch March 17, 2022 20:31
@goodov goodov restored the issues/21731 branch March 21, 2022 06:27
brave-builds pushed a commit that referenced this pull request Mar 21, 2022
brave-builds pushed a commit that referenced this pull request Mar 21, 2022
@goodov goodov deleted the issues/21731 branch March 21, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set GOMACTL_USE_PROXY=false for goma
3 participants