Skip to content

Added context menu to brave vpn toolbar button #12328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Feb 18, 2022

fix brave/brave-browser#21163

Context menu will be shown with right click or long press.
For not purchased user, only hiding button menu is visible.
For purchased user, feedback, about vpn and manage vpn menu are
also added.

Context menu for not purchased user.
image

for purchased user.
image

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Right click or long press on the vpn button
  2. Check context menu is launched
  3. Click hide and check button is hidden

fix brave/brave-browser#21163

Context menu will be shown with right click or long press.
For not purchased user, only hiding button menu is visible.
For purchased user, feedback, about vpn and manage vpn menu are
also added.
@simonhong simonhong self-assigned this Feb 18, 2022
@nullhook nullhook self-requested a review February 18, 2022 04:40
@simonhong simonhong merged commit cd6b4c0 into master Feb 18, 2022
@simonhong simonhong deleted the brave_vpn_button_context_menu branch February 18, 2022 05:05
@simonhong simonhong added this to the 1.37.x - Nightly milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPN should have a right click to hide
2 participants