Skip to content

Do not allow unlocking without the device id and fix error message for Ledger #12291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 16, 2022

Resolves brave/brave-browser#21137

This happens only when importing accounts first time and only if Ledger device is locked at that time. We throw wrong error and then user cannot import accounts as result of the previous error, retries will be successful

image

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Clean profile after install
  2. Connect and lock ledger
  3. Create/Restore Brave Wallet
  4. Try to import accounts when device locked
  5. See error message with $1
  6. Unlock Ledger and import accounts
  7. Import failed

Do not allow unlocking without the device id
@spylogsster spylogsster requested review from bbondy and onyb February 16, 2022 10:12
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 16, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@spylogsster spylogsster merged commit 5e9e379 into master Feb 16, 2022
@spylogsster spylogsster deleted the brave-21137 branch February 16, 2022 14:22
@spylogsster spylogsster added this to the 1.37.x - Nightly milestone Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when importing an account on a clean profile
3 participants