Skip to content

Remove resize limitation for PictureInPicture overlay window #12066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2022
Merged

Remove resize limitation for PictureInPicture overlay window #12066

merged 1 commit into from
Jan 31, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jan 30, 2022 •
edited
Loading

Resolves brave/brave-browser#20789

By default size of the window to resize is limited by half of available size, it is inconvenient for cases when you want to put video for second monitor or using VR displays. This PR allows to resize for full available work area.

2022-01-29_22h28_54.mp4

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Open PictureInPicture and resize video for fill available display size

@spylogsster spylogsster self-assigned this Jan 30, 2022
@spylogsster spylogsster marked this pull request as ready for review January 30, 2022 09:21
@spylogsster spylogsster requested review from a team as code owners January 30, 2022 09:21
@spylogsster spylogsster requested a review from mkarolin January 30, 2022 09:21
@github-actions github-actions bot removed the rebase label Jan 30, 2022
@spylogsster spylogsster force-pushed the issue-20789 branch 2 times, most recently from ff76223 to 783f052 Compare January 30, 2022 11:10
goodov
goodov reviewed Jan 31, 2022
View reviewed changes
patches/chrome-browser-ui-views-overlay-overlay_window_views.cc.patch Outdated
return;

max_size_ = new_max_size;
-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an empty line should be kept

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

mkarolin
mkarolin approved these changes Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spylogsster spylogsster merged commit 93b2b94 into master Jan 31, 2022
@spylogsster spylogsster deleted the issue-20789 branch January 31, 2022 17:39
@spylogsster spylogsster added this to the 1.37.x - Nightly milestone Jan 31, 2022
muliswilliam pushed a commit that referenced this pull request Feb 8, 2022
@spylogsster @muliswilliam
Remove resize limitation for PictureInPicture overlay window (#12066)
6392f21
@btlechowski btlechowski mentioned this pull request Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petemill petemill petemill approved these changes

@goodov goodov goodov approved these changes

@mkarolin mkarolin mkarolin approved these changes

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@spylogsster spylogsster

Labels
None yet
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging this pull request may close these issues.

Remove resize limitation for PictureInPicture window
4 participants
@spylogsster @petemill @goodov @mkarolin