Skip to content

chore(wallet): Don't Fetch Prices for 0 Balances #11731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

Douglashdaniel
Copy link
Contributor

Description

For better optimization and to prevent unnecessary api calls, we no longer fetch Prices and PriceHistory for a users visibleAssets that have a 0 balance.

Resolves brave/brave-browser#20280

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel added this to the 1.36.x - Nightly milestone Jan 4, 2022
@Douglashdaniel Douglashdaniel merged commit de7d94f into master Jan 4, 2022
@Douglashdaniel Douglashdaniel deleted the dont-fetch-prices-for-zero-balances branch January 4, 2022 17:06
brave-builds pushed a commit that referenced this pull request Jan 6, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.36.31 Chromium: 97.0.4692.71 (Official Build) nightly (arm64)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS macOS Version 12.1 (Build 21C52)
  • Verified steps from PR description
  • Verified there is no fetch price call done to ratios server when the wallet balance is 0 on a new wallet
  • Verified selecting ETH performs a fetch price call even when ETH balance is 0
  • Verified selecting BAT performs a fetch price call even when BAT balance is 0
  • Verified locking and unlocking the wallet on a zero balance wallet doesn't do any more fetch calls
  • Verified quit and relaunch browser doesn't do a fetch call on a zero balance wallet
  • Verified if there is wallet balance then appropriate call is done on the above scenarios to get the price balance
Clean Wallet Launch ETH Fetch Price BAT Fetch Price Lock Wallet/Restart browser
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't fetch prices for assets with a 0 balance
4 participants