Add feedback/indicator when copying recovery phrase #11535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muliswilliam
changed the title
muliswilliam
changed the title
components/brave_wallet_ui/components/desktop/wallet-onboarding/recovery/index.tsx
Outdated
Show resolved
Hide resolved
petemill
reviewed
Dec 9, 2021
| @@ -25,11 +26,12 @@ export interface Props { | |||
| isRecoveryTermsAccepted: boolean | |||
| onSubmitTerms: (key: string, selected: boolean) => void | |||
| recoverPhrase: string[] | |||
| recoverPhraseCopied: boolean | |||
There was a problem hiding this comment.
isRecoverPhraseCopied seems to fit more with existing pattern for booleans
| } | ||
|
|
||
| React.useEffect(() => { | ||
| const timer = setTimeout(() => { |
There was a problem hiding this comment.
nit: if !recoverPhraseCopied then don't need to set timeout
| @@ -84,6 +84,7 @@ | |||
| <message name="IDS_BRAVE_WALLET_SWAP_FEES_NOTICE" desc="Swap fees notice">Quote includes a 0.875% Brave fee.</message> | |||
| <message name="IDS_BRAVE_WALLET_BUTTON_CONTINUE" desc="General Continue button">Continue</message> | |||
| <message name="IDS_BRAVE_WALLET_BUTTON_COPY" desc="General Copy button">Copy</message> | |||
| <message name="IDS_BRAVE_WALLET_BUTTON_COPIED" desc="General Copied button">Copied</message> | |||
There was a problem hiding this comment.
Perhaps a more useful description for translators would be "Confirmation that text has been copied to clipboard"
muliswilliam
force-pushed
the
add-indicator-when-copying-recover-phrase
branch
from
33a356b to
7b38ddc
Compare
petemill
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to indicate when a user copies recovery phrase by:
The button resets back to 'Copy' after 5 seconds.
Resolves brave/brave-browser#19021
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
Copy.Recover.Phrase.Feedback.mov